[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH 0/2] mtd: nand: fix regression introduced by splitting off manufacturer dependent code
On Tue, 29 Aug 2017 12:17:11 +0200
Lothar Waßmann <> wrote:

> commit c51d0ac59f24 ("mtd: nand: Move Samsung specific init/detection
> logic in nand_samsung.c") introduced a regression for Samsung SLC NAND
> chips by skipping the initialization of chip->bits_per_cell that is
> done in nand_decode_ext_id() from which the manufacturer dependent
> code was extracted.
> The regression should also affect Hynix and Macronix chips whose code
> was separated out in further commits but which I cannot test.
> AMD/Spansion and Toshiba NAND are not affected, since they are calling
> nand_decode_ext_id() (which initializes bhip->bits_per_cell) in their
> .detect function.
> Fix the regression and add a warning to nand_is_slc() to prevent
> further regressions of this kind.

Applied both to nand/next and generated a new PR to push this in 4.14.
Also added the Fixes and Cc-stable tag to the first patch.



 \ /
  Last update: 2017-08-31 13:19    [W:0.053 / U:6.828 seconds]
©2003-2018 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site