Messages in this thread | | | Date | Thu, 31 Aug 2017 12:53:17 +0200 | From | Robert Richter <> | Subject | Re: [PATCH v6 4/4] perf vendor events arm64: Add ThunderX2 implementation defined pmu core events |
| |
Shaokun,
On 31.08.17 18:29:01, Zhangshaokun wrote: > On 2017/8/29 20:47, Robert Richter wrote: > > On 29.08.17 17:26:00, Zhangshaokun wrote: > >> On 2017/8/24 20:03, Ganapatrao Kulkarni wrote: > >>> This is not a full event list, but a short list of useful events. > >>> > >>> Signed-off-by: Ganapatrao Kulkarni <ganapatrao.kulkarni@cavium.com> > >>> --- > >>> tools/perf/pmu-events/arch/arm64/mapfile.csv | 15 ++++++ > >>> .../arm64/thunderx2/implementation-defined.json | 62 ++++++++++++++++++++++ > >>> 2 files changed, 77 insertions(+) > >>> create mode 100644 tools/perf/pmu-events/arch/arm64/mapfile.csv > >>> create mode 100644 tools/perf/pmu-events/arch/arm64/thunderx2/implementation-defined.json > >>> > >> > >> I saw you also used thunderx2 in tools/perf/pmu-events/arch/arm64/, how about John's suggestion > >> that would use vendor sub-folder? > >> Of course, appreciate maintainer's comments. > > > > this would just add another level of subdirectories. I rather would > > prefer to have a per platform dir comparable to what is listed in > > > > arch/arm64/Kconfig.platforms > > > > Check it again that not all vendors have specific platform config per SoC family, > so this would not work for us (HiSilicon) and maybe some other vendors.
Even if there is no specific platform defined in Kconfig, you still could create a platform dir in tools/perf/. There must not be a 1:1 mapping. DT compatible strings may give a hint for naming then.
-Robert
| |