lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRE: [PATCH] RM64: dts: ls208xa: Add iommu-map property for pci
Date

> -----Original Message-----
> From: Marc Zyngier [mailto:marc.zyngier@arm.com]
> Sent: Thursday, August 31, 2017 3:02 PM
> To: Bharat Bhushan <bharat.bhushan@nxp.com>; robh+dt@kernel.org;
> ark.rutland@arm.com; will.deacon@arm.com; oss@buserror.net; Gang Liu
> <gang.liu@nxp.com>; devicetree@vger.kernel.org; linux-arm-
> kernel@lists.infradead.org; linux-kernel@vger.kernel.org;
> catalin.marinas@arm.com
> Subject: Re: [PATCH] RM64: dts: ls208xa: Add iommu-map property for pci
>
> On 31/08/17 10:23, Bharat Bhushan wrote:
> > This patch adds iommu-map property for PCIe, which enables SMMU for
> > these devices on LS208xA devices.
> >
> > Signed-off-by: Bharat Bhushan <Bharat.Bhushan@nxp.com>
> > ---
> > arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> > b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> > index 94cdd30..67cf605 100644
> > --- a/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> > +++ b/arch/arm64/boot/dts/freescale/fsl-ls208xa.dtsi
> > @@ -606,6 +606,7 @@
> > num-lanes = <4>;
> > bus-range = <0x0 0xff>;
> > msi-parent = <&its>;
> > + iommu-map = <0 &smmu 0 1>; /* This is fixed-up by
> u-boot */
>
> What does this do when your version of u-boot doesn't fill this in for you?

Good question, frankly I have not thought of this case before.
But if we pass length = 0 in above property then no fixup happen with happen with older u-boot. In this case of_iommu_configure() will return NULL iommu-ops and it switch to swio-tlb. Will that work?

Thanks
-Bharat

>
> Thanks,
>
> M.
> --
> Jazz is not dead. It just smells funny...
\
 
 \ /
  Last update: 2017-08-31 12:42    [W:0.078 / U:4.412 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site