lkml.org 
[lkml]   [2017]   [Aug]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 4/4] lockdep: Fix workqueue crossrelease annotation
On Thu, Aug 31, 2017 at 10:04:42AM +0200, Peter Zijlstra wrote:
> On Wed, Aug 30, 2017 at 08:25:46PM +0900, Byungchul Park wrote:
>
> > For example - I'm giving you the same example repeatedly:
> >
> > context X context Y
> > --------- ---------
> > wait_for_completion(C)
> > acquire(A)
> > process_one_work()
> > acquire(B)
> > work->fn()
> > complete(C)
> >
> > Please check C->A and C->B.
>
> Is there a caller of procesS_one_work() that holds a lock?

It's not important. Ok, check the following, instead:

context X context Y
--------- ---------
wait_for_completion(C)
acquire(A)
release(A)
process_one_work()
acquire(B)
release(B)
work->fn()
complete(C)

We don't need to lose C->A and C->B dependencies unnecessarily.

\
 
 \ /
  Last update: 2017-08-31 10:15    [W:0.105 / U:35.252 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site