lkml.org 
[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/16] fs: fix kernel_write prototype
On Wed, Aug 30, 2017 at 04:59:57PM +0200, Christoph Hellwig wrote:

> for (prot = 0; prot < prot_length;) {
> sector_t len = min_t(sector_t, bufsize, prot_length - prot);
> - ssize_t ret = kernel_write(prot_fd, buf, len, pos + prot);
> + ssize_t ret = kernel_write(prot_fd, buf, len, &pos);
>
> if (ret != len) {
> pr_err("vfs_write to prot file failed: %zd\n", ret);
> return ret < 0 ? ret : -ENODEV;
> }
> - prot += ret;
> }

And that loop will terminate because of...? IOW, the same bug class as in
the kernel_read() patch.

\
 
 \ /
  Last update: 2017-08-30 17:39    [W:0.204 / U:0.452 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site