lkml.org 
[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 1/2] ARM: dts: sun7i: Fix A20-OLinuXino-MICRO dts for LAN8710
    Hi,

    On Mon, Aug 28, 2017 at 09:32:42AM +0300, Stefan Mavrodiev wrote:
    > From revision J the board uses new phy chip LAN8710. Compared
    > with RTL8201, RA17 pin is TXERR. It has pullup which causes phy
    > not to work. To fix this PA17 is muxed with GMAC function. This
    > makes the pin output-low.
    >
    > This patch is compatible with earlier board revisions, since this
    > pin wasn't connected to phy.
    >
    > Signed-off-by: Stefan Mavrodiev <stefan@olimex.com>
    > ---
    > arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts | 7 ++++++-
    > 1 file changed, 6 insertions(+), 1 deletion(-)
    >
    > diff --git a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
    > index 0b7403e..cb1b081 100644
    > --- a/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
    > +++ b/arch/arm/boot/dts/sun7i-a20-olinuxino-micro.dts
    > @@ -102,7 +102,7 @@
    >
    > &gmac {
    > pinctrl-names = "default";
    > - pinctrl-0 = <&gmac_pins_mii_a>;
    > + pinctrl-0 = <&gmac_pins_mii_a>,<&gmac_txerr>;
    > phy = <&phy1>;
    > phy-mode = "mii";
    > status = "okay";
    > @@ -229,6 +229,11 @@
    > };
    >
    > &pio {
    > + gmac_txerr: gmac_txerr@0 {
    > + pins = "PA17";
    > + function = "gmac";
    > + };
    > +

    The patch looks fine, I still have one question though.

    Can a PHY operate without this signal? My real question is, would it
    make sense to mux that pin for all the users, or is it an optional
    signal that each board designer can choose to use or not?

    Thanks!
    Maxime

    --
    Maxime Ripard, Free Electrons
    Embedded Linux and Kernel engineering
    http://free-electrons.com
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2017-08-30 16:38    [W:3.645 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site