Messages in this thread | | | Date | Wed, 30 Aug 2017 21:28:52 +0900 | From | Masami Hiramatsu <> | Subject | Re: [PATCH] perf probe: Fix kprobe blacklist checking condition |
| |
On Tue, 29 Aug 2017 20:57:23 +0800 Li Bin <huawei.libin@huawei.com> wrote:
> The commit 9aaf5a5("perf probe: Check kprobes blacklist > when adding new events"), perf probe supports checking > the blacklist of the fuctions which can not be probed. > But the checking condition is wrong, that the end_addr > of the symbol which is the start_addr of the next symbol > can't be included.
Oops, right.
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Thanks!
BTW, should we use memory_contains() macro for this check too...
> > Signed-off-by: Li Bin <huawei.libin@huawei.com> > --- > tools/perf/util/probe-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index a2670e9..bf7c928 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2373,7 +2373,7 @@ static int kprobe_blacklist__load(struct list_head *blacklist) > struct kprobe_blacklist_node *node; > > list_for_each_entry(node, blacklist, list) { > - if (node->start <= address && address <= node->end) > + if (node->start <= address && address < node->end) > return node; > } > > -- > 1.7.12.4 >
-- Masami Hiramatsu <mhiramat@kernel.org>
| |