Messages in this thread | | | Date | Tue, 29 Aug 2017 22:39:20 -0700 (PDT) | Subject | Re: [PATCH net-next v3 0/3] NCSI VLAN Filtering Support | From | David Miller <> |
| |
From: Samuel Mendoza-Jonas <sam@mendozajonas.com> Date: Wed, 30 Aug 2017 14:37:21 +1000
> On Mon, 2017-08-28 at 16:50 -0700, David Miller wrote: >> From: Samuel Mendoza-Jonas <sam@mendozajonas.com> >> Date: Mon, 28 Aug 2017 16:18:40 +1000 >> >> > This series (mainly patch 2) adds VLAN filtering to the NCSI implementation. >> > A fair amount of code already exists in the NCSI stack for VLAN filtering but >> > none of it is actually hooked up. This goes the final mile and fixes a few >> > bugs in the existing code found along the way (patch 1). >> > >> > Patch 3 adds the appropriate flag and callbacks to the ftgmac100 driver to >> > enable filtering as it's a large consumer of NCSI (and what I've been >> > testing on). >> > >> > v3: - Add comment describing change to ncsi_find_filter() >> > - Catch NULL in clear_one_vid() from ncsi_get_filter() >> > - Simplify state changes when kicking updated channel >> >> Series applied. > > Thanks David, > > The kbuild bot caught a build error where the add/kill callbacks aren't > defined without CONFIG_NET_NCSI: > >>> ERROR: "ncsi_vlan_rx_kill_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined! >>> ERROR: "ncsi_vlan_rx_add_vid" [drivers/net/ethernet/faraday/ftgmac100.ko] undefined! > > It's a quick fixup to patch 3 as below, would you like me to send it as a v4?
You must submit a formal fixup patch to fix bugs if I've said that I've already applied your patch.
| |