lkml.org 
[lkml]   [2017]   [Aug]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] staging: ks7010: Fix coding style and remove checkpatch.pl warnings.
On Tue, Aug 29, 2017 at 08:57:34PM -0600, Jonathan Whitaker wrote:
> It is prefered to use '"%s...", __func__ instead of function names for
> logging. This commit replaces hardcoded function name strings to the
> more preferred '"%s...", __func__' style. These warnings were reported
> by checkpatch.pl.
>
> Signed-off-by: Jonathan Whitaker <jon.b.whitaker@gmail.com>
>
> Changes in v2:
> - Wrapped the changelog text to 72 columns.
> - Fixed the commit subject to be more clear.
> ---

Put the Changelog under the --- cut off line.

> drivers/staging/ks7010/ks7010_sdio.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/ks7010/ks7010_sdio.c b/drivers/staging/ks7010/ks7010_sdio.c
> index 9b28ee1..c0e91c3 100644
> --- a/drivers/staging/ks7010/ks7010_sdio.c
> +++ b/drivers/staging/ks7010/ks7010_sdio.c
> @@ -834,7 +834,7 @@ static int ks7010_sdio_probe(struct sdio_func *func,
> unsigned char byte;
> int ret;
>
> - DPRINTK(5, "ks7010_sdio_probe()\n");
> + DPRINTK(5, "%s()\n", __func__);

Just delete both the printks. You can get the same information with
ftrace.

regards,
dan carpenter

\
 
 \ /
  Last update: 2017-08-30 11:58    [W:0.057 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site