Messages in this thread | | | Date | Wed, 30 Aug 2017 11:25:28 +0900 | From | Sergey Senozhatsky <> | Subject | Re: printk: what is going on with additional newlines? |
| |
On (08/29/17 18:52), Joe Perches wrote: [..] > > We could simply add a seq_buf_printk() that is implemented in the printk > > proper, to parse the seq_buf buffer properly, and add the timestamps and > > such. > > No need. printk would already add timestamps.
the idea is not to do printk() on that seq buffer at all, but to log_store(), atomically, seq buffer messages
spin_lock(&logbuf_lock) while (offset < seq_buffer->len) { ... log_store(seq->buffer + offset); ... } spin_unlock(&logbuf_unlock)
-ss
| |