lkml.org 
[lkml]   [2017]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 15/30] xfs: Define usercopy region in xfs_inode slab cache
    On Tue, Aug 29, 2017 at 01:14:53AM -0700, Christoph Hellwig wrote:
    > One thing I've been wondering is wether we should actually just
    > get rid of the online area. Compared to reading an inode from
    > disk a single additional kmalloc is negligible, and not having the
    > inline data / extent list would allow us to reduce the inode size
    > significantly.

    Probably should. I've already been looking at killing the inline
    extents array to simplify the management of the extent list (much
    simpler to index by rbtree when we don't have direct/indirect
    structures), so killing the inline data would get rid of the other
    part of the union the inline data sits in.

    OTOH, if we're going to have to dynamically allocate the memory for
    the extent/inline data for the data fork, it may just be easier to
    make the entire data fork a dynamic allocation (like the attr fork).

    Cheers,

    Dave.
    --
    Dave Chinner
    david@fromorbit.com

    \
     
     \ /
      Last update: 2017-08-29 14:32    [W:4.149 / U:0.056 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site