lkml.org 
[lkml]   [2017]   [Aug]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86/Kconfig: compile 32bit drivers for COMPILE_TEST

* Hannes Reinecke <hare@suse.de> wrote:

> When COMPILE_TEST is set we should be compiling 32-bit only
> drivers and features (like ISA support etc), too.
> After all, it's a compile test.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> arch/x86/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/x86/Kconfig b/arch/x86/Kconfig
> index 781521b7cf9e..df61bc37b1a2 100644
> --- a/arch/x86/Kconfig
> +++ b/arch/x86/Kconfig
> @@ -2548,7 +2548,7 @@ config ISA_DMA_API
> Enables ISA-style DMA support for devices requiring such controllers.
> If unsure, say Y.
>
> -if X86_32
> +if X86_32 || COMPILE_TEST
>
> config ISA
> bool "ISA support"

This is almost certainly a bad idea: if it's a compile test, why not compile test
the 32-bit kernel, which will include these drivers?

These are drivers that have probably been ever been built in 64-bit mode, and now
an allmodconfig/allyesconfig will turn them on...

Thanks,

Ingo

\
 
 \ /
  Last update: 2017-08-29 13:46    [W:0.137 / U:0.248 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site