lkml.org 
[lkml]   [2017]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH v4 3/7] media: open.rst: remove the minor number range
    From
    Date
    On 26/08/17 13:53, Mauro Carvalho Chehab wrote:
    > minor numbers use to range between 0 to 255, but that
    > was changed a long time ago. While it still applies when
    > CONFIG_VIDEO_FIXED_MINOR_RANGES, when the minor number is
    > dynamically allocated, this may not be true. In any case,
    > this is not relevant, as udev will take care of it.
    >
    > So, remove this useless misinformation.
    >
    > Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>

    Acked-by: Hans Verkuil <hans.verkuil@cisco.com>

    > ---
    > Documentation/media/uapi/v4l/open.rst | 9 ++++-----
    > 1 file changed, 4 insertions(+), 5 deletions(-)
    >
    > diff --git a/Documentation/media/uapi/v4l/open.rst b/Documentation/media/uapi/v4l/open.rst
    > index fc0037091814..96ac972c1fa2 100644
    > --- a/Documentation/media/uapi/v4l/open.rst
    > +++ b/Documentation/media/uapi/v4l/open.rst
    > @@ -19,11 +19,10 @@ helper functions and a common application interface specified in this
    > document.
    >
    > Each driver thus loaded registers one or more device nodes with major
    > -number 81 and a minor number between 0 and 255. Minor numbers are
    > -allocated dynamically unless the kernel is compiled with the kernel
    > -option CONFIG_VIDEO_FIXED_MINOR_RANGES. In that case minor numbers
    > -are allocated in ranges depending on the device node type (video, radio,
    > -etc.).
    > +number 81. Minor numbers are allocated dynamically unless the kernel
    > +is compiled with the kernel option CONFIG_VIDEO_FIXED_MINOR_RANGES.

    I wonder if we shouldn't remove this kernel option completely. Does it
    make any sense to keep holding on to this?

    Regards,

    Hans

    > +In that case minor numbers are allocated in ranges depending on the
    > +device node type.
    >
    > The existing V4L2 device node types are:
    >
    >

    \
     
     \ /
      Last update: 2017-08-28 11:10    [W:4.622 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site