lkml.org 
[lkml]   [2017]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.4 29/53] drm: rcar-du: Fix H/V sync signal polarity configuration
    Date
    4.4-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Koji Matsuoka <koji.matsuoka.xm@renesas.com>

    commit fd1adef3bff0663c5ac31b45bc4a05fafd43d19b upstream.

    The VSL and HSL bits in the DSMR register set the corresponding
    horizontal and vertical sync signal polarity to active high. The code
    got it the wrong way around, fix it.

    Signed-off-by: Koji Matsuoka <koji.matsuoka.xm@renesas.com>
    Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
    Signed-off-by: Thong Ho <thong.ho.px@rvc.renesas.com>
    Signed-off-by: Nhan Nguyen <nhan.nguyen.yb@renesas.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/gpu/drm/rcar-du/rcar_du_crtc.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    --- a/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
    +++ b/drivers/gpu/drm/rcar-du/rcar_du_crtc.c
    @@ -148,8 +148,8 @@ static void rcar_du_crtc_set_display_tim
    rcar_du_group_write(rcrtc->group, rcrtc->index % 2 ? OTAR2 : OTAR, 0);

    /* Signal polarities */
    - value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? 0 : DSMR_VSL)
    - | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? 0 : DSMR_HSL)
    + value = ((mode->flags & DRM_MODE_FLAG_PVSYNC) ? DSMR_VSL : 0)
    + | ((mode->flags & DRM_MODE_FLAG_PHSYNC) ? DSMR_HSL : 0)
    | DSMR_DIPM_DE | DSMR_CSPM;
    rcar_du_crtc_write(rcrtc, DSMR, value);


    \
     
     \ /
      Last update: 2017-08-28 10:35    [W:4.081 / U:0.380 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site