lkml.org 
[lkml]   [2017]   [Aug]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] staging: rtl8723bs: remove memset before memcpy
On Mon, Aug 28, 2017 at 09:19:06AM +0300, Dan Carpenter wrote:
> On Mon, Aug 28, 2017 at 01:43:31AM +0530, Himanshu Jha wrote:
> > calling memcpy immediately after memset with the same region of memory
> > makes memset redundant.
> >
> > Build successfully.
> >
>
> Thanks for the patch, it looks good. You don't need to say that it
> builds successfully, because we already assume that's true.
>
> > Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> > ---
>
> Sometimes I put a comment here under the cut off line if I want people
> to know that I haven't tested a patch.
>
> Anyway, don't resend the patch. It's fine as-is (unless Greg
> complains) but it's just for future reference.

Thanks for the feedback and i will keep that in mind for future patches.
Himanshu Jha
>
> regards,
> dan carpenter
>

\
 
 \ /
  Last update: 2017-08-28 09:19    [W:0.038 / U:2.208 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site