lkml.org 
[lkml]   [2017]   [Aug]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] tty: serial: 8250_mtk: Use PTR_ERR_OR_ZERO
From
Date


On 08/27/2017 09:31 AM, Himanshu Jha wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com>
> ---
> drivers/tty/serial/8250/8250_mtk.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c
> index ce0cc47..fb45770 100644
> --- a/drivers/tty/serial/8250/8250_mtk.c
> +++ b/drivers/tty/serial/8250/8250_mtk.c
> @@ -171,10 +171,7 @@ static int mtk8250_probe_of(struct platform_device *pdev, struct uart_port *p,
> }
>
> data->bus_clk = devm_clk_get(&pdev->dev, "bus");
> - if (IS_ERR(data->bus_clk))
> - return PTR_ERR(data->bus_clk);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(data->bus_clk);
> }
>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

\
 
 \ /
  Last update: 2017-08-27 20:50    [W:0.040 / U:0.304 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site