lkml.org 
[lkml]   [2017]   [Aug]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
Subject[PATCH 3/3] staging: lustre: obdclass: fix checking for obd_init_checks()
The obd_init_checks() function can either return -EOVERFLOW or -EINVAL
but we accidentally ignore -EINVAL returns.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
This patch is the right thing, but it's always a bit risky turning on
new checks and I haven't tested this.

diff --git a/drivers/staging/lustre/lustre/obdclass/class_obd.c b/drivers/staging/lustre/lustre/obdclass/class_obd.c
index 545358923271..2df218b010e1 100644
--- a/drivers/staging/lustre/lustre/obdclass/class_obd.c
+++ b/drivers/staging/lustre/lustre/obdclass/class_obd.c
@@ -448,7 +448,7 @@ static int __init obdclass_init(void)
obd_zombie_impexp_init();

err = obd_init_checks();
- if (err == -EOVERFLOW)
+ if (err)
return err;

class_init_uuidlist();
\
 
 \ /
  Last update: 2017-08-26 08:06    [W:0.034 / U:23.900 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site