lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name
On Thu, Aug 24, 2017 at 11:40 AM, Eric W. Biederman
<ebiederm@xmission.com> wrote:
>
> Here is my tested version of the patch.

Can you please take my cleanups to devpts_ptmx_path() too?

Those 'goto err' statements are disgusting, when a plain 'return
-ERRNO' works cleaner.

And that "struct file *filp = NULL;" is bogus - you added the NULL
initialization because you mis-used "filp" early, and with that fixed
it's just garbage.

Other than that, it looks fine to me.

Linus

\
 
 \ /
  Last update: 2017-08-24 20:51    [W:0.180 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site