Messages in this thread | | | From | Linus Torvalds <> | Date | Thu, 24 Aug 2017 10:52:21 -0700 | Subject | Re: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name |
| |
On Thu, Aug 24, 2017 at 8:54 AM, Eric W. Biederman <ebiederm@xmission.com> wrote: > > Weird. There is at least one leak inducing bug in there. So perhaps > that is the cause. *Scratches my head* Are you also testing the new > ioctl?
I can verify, and it's not the leak. I tried your patch with that leak fix (and the other fixes I pointed out), and I see similar issues that Stefan noted.
With gnome-terminal, the terminal window opens, and then it says
Failed to open PTY: No such device
and the terminal obviously doesn't work.
And I see the error: your devpts_ptmx_path() code always returns -ENODEV because you set the error unconditionally before an error check, and then you don't clear it if the error didn't happen.
I'll test the fix.
Linus
| |