lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/10] perf values: Fix allocation check
    Date
    Bailing out in case the allocation failed,
    not the other way round.

    Signed-off-by: Jiri Olsa <jolsa@kernel.org>
    ---
    tools/perf/util/values.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/tools/perf/util/values.c b/tools/perf/util/values.c
    index 9ac36bf2c438..2c4af02f08cd 100644
    --- a/tools/perf/util/values.c
    +++ b/tools/perf/util/values.c
    @@ -131,7 +131,7 @@ static int perf_read_values__enlarge_counters(struct perf_read_values *values)
    for (i = 0; i < values->threads; i++) {
    u64 *value = realloc(values->value[i], counters_max * sizeof(**values->value));

    - if (value) {
    + if (!value) {
    pr_debug("failed to enlarge read_values ->values array");
    goto out_free_name;
    }
    --
    2.9.5
    \
     
     \ /
      Last update: 2017-08-24 18:30    [W:2.616 / U:0.108 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site