lkml.org 
[lkml]   [2017]   [Aug]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] irqchip: mmp: make mmp_intc_conf const
Date
On Thu, Aug 24 2017 at  3:56:21 pm BST, Bhumika Goyal <bhumirks@gmail.com> wrote:
> Make these const as they are only used during a copy operation. Done
> using Coccinelle.
>
> @match disable optional_qualifier@
> identifier s;
> @@
> static struct mmp_intc_conf s = {...};
>
> @ref@
> position p;
> identifier match.s;
> @@
> s@p
>
> @good1@
> position ref.p;
> identifier match.s,f,c;
> expression e;
> @@
> (
> e = s@p
> |
> e = s@p.f
> |
> c(...,s@p.f,...)
> |
> c(...,s@p,...)
> )
>
> @bad depends on !good1@
> position ref.p;
> identifier match.s;
> @@
> s@p
>
> @depends on forall !bad disable optional_qualifier@
> identifier match.s;
> @@
> static
> + const
> struct mmp_intc_conf s;
>
> Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>

Can you please post these fixes as a series instead of individual
patches? It would make the maintainers' life much easier. I'll apply
this patch anyway, but please keep this in mind for the future.

Thanks,

M.
--
Jazz is not dead, it just smell funny.

\
 
 \ /
  Last update: 2017-08-24 12:40    [W:0.612 / U:0.120 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site