Messages in this thread | | | Date | Thu, 24 Aug 2017 10:45:56 +0200 | From | Christoph Hellwig <> | Subject | Re: [PATCH v2 1/1] bsg-lib: fix kernel panic resulting from missing allocation of reply-buffer |
| |
> /** > - * bsg_destroy_job - routine to teardown/delete a bsg job > + * bsg_teardown_job - routine to teardown a bsg job > * @job: bsg_job that is to be torn down > */ > -static void bsg_destroy_job(struct kref *kref) > +static void bsg_teardown_job(struct kref *kref)
Why this rename? The destroy name seems to be one of the most common patterns for the kref_put callbacks.
Otherwise this looks fine:
Reviewed-by: Christoph Hellwig <hch@lst.de>
| |