Messages in this thread | | | From | Andy Shevchenko <> | Date | Tue, 22 Aug 2017 20:40:06 +0300 | Subject | Re: [PATCH v7 5/7] io-64-nonatomic: add io{read|write}64[be]{_lo_hi|_hi_lo} macros |
| |
On Tue, Aug 22, 2017 at 8:02 PM, Logan Gunthorpe <logang@deltatee.com> wrote: > This patch adds generic io{read|write}64[be]{_lo_hi|_hi_lo} macros if > they are not already defined by the architecture. (As they are provided > by the generic iomap library). > > The patch also points io{read|write}64[be] to the variant specified by the > header name. > > This is because new drivers are encouraged to use ioreadXX, et al instead > of readX[1], et al -- and mixing ioreadXX with readq is pretty ugly. > > [1] ldd3: section 9.4.2
ldd -> LDD
It's a pretty outdated book, though quite many chapters are actual for these days.
Recomendation is kinda arguable. I doubt modern architectures make difference between IO operations and MMIO. Does, for example, PCI requires some special signal (message / wire) handling when pio_*() accessors used vs. mmio_*() ones?
> cc: Christoph Hellwig <hch@lst.de> > cc: Arnd Bergmann <arnd@arndb.de> > cc: Alan Cox <gnomes@lxorguk.ukuu.org.uk> > cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
cc -> Cc ?
-- With Best Regards, Andy Shevchenko
| |