Messages in this thread | | | Date | Tue, 22 Aug 2017 16:49:23 +0200 | From | Takashi Iwai <> | Subject | Re: [alsa-devel] ALSA: pcsp: Use common error handling code in snd_card_pcsp_probe() |
| |
On Tue, 22 Aug 2017 16:36:35 +0200, SF Markus Elfring wrote: > > >> I got the impression that the functions which are called at the updated places > >> by the function “snd_card_pcsp_probe” indicate a successful execution > >> only by zero so far. > > > > You have the impression, great. > > This aspect is also a general programming interface issue for some functions. > > > > And what's the reason to drop the negative check? > > * I find it a bit safer when the error predicate is “return value != 0”.
Can't agree. And I have no interest to continue bike-shedding, sorry. You can't convince me regarding this.
Takashi
| |