Messages in this thread Patch in this message | | | Date | Mon, 21 Aug 2017 02:20:30 -0700 | From | tip-bot for Arvind Yadav <> | Subject | [tip:efi/core] firmware/efi/esrt: Constify attribute_group structures |
| |
Commit-ID: f1a5b53570001b1bcbf890ac6c4be1db99f8cc28 Gitweb: http://git.kernel.org/tip/f1a5b53570001b1bcbf890ac6c4be1db99f8cc28 Author: Arvind Yadav <arvind.yadav.cs@gmail.com> AuthorDate: Fri, 18 Aug 2017 20:49:47 +0100 Committer: Ingo Molnar <mingo@kernel.org> CommitDate: Mon, 21 Aug 2017 09:43:51 +0200
firmware/efi/esrt: Constify attribute_group structures
attribute_group are not supposed to change at runtime. All functions working with attribute_group provided by <linux/sysfs.h> work with const attribute_group. So mark the non-const structs as const.
Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: http://lkml.kernel.org/r/20170818194947.19347-15-ard.biesheuvel@linaro.org Signed-off-by: Ingo Molnar <mingo@kernel.org> --- drivers/firmware/efi/esrt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/firmware/efi/esrt.c b/drivers/firmware/efi/esrt.c index 8554d7a..bd7ed3c 100644 --- a/drivers/firmware/efi/esrt.c +++ b/drivers/firmware/efi/esrt.c @@ -230,7 +230,7 @@ static umode_t esrt_attr_is_visible(struct kobject *kobj, return attr->mode; } -static struct attribute_group esrt_attr_group = { +static const struct attribute_group esrt_attr_group = { .attrs = esrt_attrs, .is_visible = esrt_attr_is_visible, };
| |