Messages in this thread | | | Subject | Re: [PATCH v3 5/5] perf annotate browser: Circulate percent, total period and samples view | From | Taeung Song <> | Date | Mon, 21 Aug 2017 14:47:09 +0900 |
| |
On 08/18/2017 11:23 PM, Arnaldo Carvalho de Melo wrote: > Em Fri, Aug 18, 2017 at 05:47:08PM +0900, Taeung Song escreveu: >> With a existing 't' hotkey, support the three view based on percent, >> total period and number of samples on the annotate TUI browser, >> circulating them like below: >> >> Percent -> Period -> Samples -> Percent ... >> >> Suggested-by: Namhyung Kim <namhyung@kernel.org> >> Cc: Milian Wolff <milian.wolff@kdab.com> >> Cc: Jiri Olsa <jolsa@redhat.com> >> Signed-off-by: Taeung Song <treeze.taeung@gmail.com> >> --- > > Ok, here I removed this part, that is not documented in the patch nor in > the 'h' help screen, if you think it should be considered, please > resubmit it with a proper explanation:
I'm really sorry. The case 'e' code is a residue.. I missed removing the code. Thank you for indicating my mistakes.
Do I resend this patchkit based on your changes ? Or, will you modify it by yourself ?
Thanks, Taeung
> > diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c > index e82e6c5df83b..ba0aee576a2b 100644 > --- a/tools/perf/ui/browsers/annotate.c > +++ b/tools/perf/ui/browsers/annotate.c > @@ -921,12 +921,6 @@ static int annotate_browser__run(struct annotate_browser *browser, > annotate_browser__opts.show_total_period = true; > annotate_browser__update_addr_width(browser); > continue; > - case 'e': > - annotate_browser__opts.show_total_period = false; > - annotate_browser__opts.show_nr_samples = > - !annotate_browser__opts.show_nr_samples; > - annotate_browser__update_addr_width(browser); > - continue; > case K_LEFT: > case K_ESC: > case 'q': >
| |