lkml.org 
[lkml]   [2017]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    SubjectRe: [PATCH 2/2] qlcnic: add const to bin_attribute structure
    Date
    -----Original Message-----
    From: Bhumika Goyal <bhumirks@gmail.com>
    Date: Wednesday, August 2, 2017 at 11:27 PM
    To: "julia.lawall@lip6.fr" <julia.lawall@lip6.fr>, "kvalo@codeaurora.org"
    <kvalo@codeaurora.org>, "linux-wireless@vger.kernel.org"
    <linux-wireless@vger.kernel.org>, "netdev@vger.kernel.org"
    <netdev@vger.kernel.org>, "linux-kernel@vger.kernel.org"
    <linux-kernel@vger.kernel.org>, Harish Patil <Harish.Patil@cavium.com>,
    "Chopra, Manish" <Manish.Chopra@cavium.com>, Dept-GE Linux NIC Dev
    <Dept-GELinuxNICDev@cavium.com>
    Cc: Bhumika Goyal <bhumirks@gmail.com>
    Subject: [PATCH 2/2] qlcnic: add const to bin_attribute structure

    >Add const to bin_attribute structure as it is only passed to the
    >functions sysfs_{remove/create}_bin_file. The corresponding
    >arguments are of type const, so declare the structure to be const.
    >
    >Signed-off-by: Bhumika Goyal <bhumirks@gmail.com>
    >---
    > drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    >diff --git a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
    >b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
    >index 73027a6..82fcb83 100644
    >--- a/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
    >+++ b/drivers/net/ethernet/qlogic/qlcnic/qlcnic_sysfs.c
    >@@ -1248,7 +1248,7 @@ static ssize_t
    >qlcnic_83xx_sysfs_flash_write_handler(struct file *filp,
    > .write = qlcnic_sysfs_write_pm_config,
    > };
    >
    >-static struct bin_attribute bin_attr_flash = {
    >+static const struct bin_attribute bin_attr_flash = {
    > .attr = {.name = "flash", .mode = (S_IRUGO | S_IWUSR)},
    > .size = 0,
    > .read = qlcnic_83xx_sysfs_flash_read_handler,
    >--
    >1.9.1
    >
    >Acked-by: Harish Patil <harish.patil@cavium.com>

    \
     
     \ /
      Last update: 2017-08-03 05:25    [W:2.849 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site