lkml.org 
[lkml]   [2017]   [Aug]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 1/5] test_kmod: make selftest executable
    On Wed, Aug 02, 2017 at 04:42:50PM -0700, Andrew Morton wrote:
    > On Wed, 2 Aug 2017 15:55:50 -0700 "Luis R. Rodriguez" <mcgrof@kernel.org> wrote:
    >
    > > On Wed, Aug 2, 2017 at 3:43 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
    > > > On Wed, 2 Aug 2017 14:14:46 -0700 "Luis R. Rodriguez" <mcgrof@kernel.org> wrote:
    > > >
    > > >> We had just forgotten to do this.
    > > >>
    > > >> Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader")
    > > >> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
    > > >> ---
    > > >> tools/testing/selftests/kmod/kmod.sh | 0
    > > >> 1 file changed, 0 insertions(+), 0 deletions(-)
    > > >> mode change 100644 => 100755 tools/testing/selftests/kmod/kmod.sh
    > > >>
    > > >> diff --git a/tools/testing/selftests/kmod/kmod.sh b/tools/testing/selftests/kmod/kmod.sh
    > > >> old mode 100644
    > > >> new mode 100755
    > > >
    > > > This is pretty fragile - I'm not sure that patch/diff are capable of
    > > > communicating a bare chmod. If someone does a "patch -p1 < patch-4.14"
    > > > or whatever, this change is likely to get lost.
    > >
    > > True if using regular diff, if using git, it will catch it though.
    >
    > Yeah. I don't think this change will make it through my
    > maze-of-scripts. Perhaps Shuah can pick it up.

    Ah sure, Shuah, can this go through your tree?

    > Also...
    >
    > # find tools/testing/selftests -name "*.sh" -a ! -executable
    > tools/testing/selftests/rcutorture/configs/rcuperf/ver_functions.sh
    > tools/testing/selftests/rcutorture/configs/lock/ver_functions.sh
    > tools/testing/selftests/rcutorture/configs/rcu/ver_functions.sh
    > tools/testing/selftests/rcutorture/bin/functions.sh
    > tools/testing/selftests/locking/ww_mutex.sh

    Best is we embrace your suggested change indeed.

    > tools/testing/selftests/kmod/kmod.sh

    That's this one.

    > tools/testing/selftests/sysctl/sysctl.sh

    and I can follow up with Shuah on this one too.

    Luis

    \
     
     \ /
      Last update: 2017-08-03 01:46    [W:3.321 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site