Messages in this thread Patch in this message | | | From | "Luis R. Rodriguez" <> | Subject | [PATCH 5/5] test_kmod: fix small memory leak on filesystem tests | Date | Wed, 2 Aug 2017 14:14:50 -0700 |
| |
From: Dan Carpenter <dan.carpenter@oracle.com>
The break was in the wrong place so file system tests don't work as intended, leaking memory at each test switch.
Fixes: 39258f448d71 ("kmod: add test driver to stress test the module loader") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reported-by: David Binderman <dcb314@hotmail.com> [mcgrof: massaged commit subject, noted memory leak issue without the fix] Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org> --- lib/test_kmod.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/test_kmod.c b/lib/test_kmod.c index 1bc06bbfc97a..ff9148969b92 100644 --- a/lib/test_kmod.c +++ b/lib/test_kmod.c @@ -746,11 +746,11 @@ static int trigger_config_run_type(struct kmod_test_device *test_dev, strlen(test_str)); break; case TEST_KMOD_FS_TYPE: - break; kfree_const(config->test_fs); config->test_driver = NULL; copied = config_copy_test_fs(config, test_str, strlen(test_str)); + break; default: mutex_unlock(&test_dev->config_mutex); return -EINVAL; -- 2.11.0
| |