Messages in this thread | | | From | Bartosz Golaszewski <> | Date | Wed, 2 Aug 2017 13:54:09 +0200 | Subject | Re: [PATCH 4/6] gpio: mxc: use devres for irq generic chip |
| |
2017-08-02 13:41 GMT+02:00 Linus Walleij <linus.walleij@linaro.org>: > On Wed, Aug 2, 2017 at 10:32 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> On Wed, Aug 2, 2017 at 11:09 AM, Alexander Stein >> <alexander.stein@systec-electronic.com> wrote: >>> On Wednesday 02 August 2017 09:51:24, Bartosz Golaszewski wrote: >>>> Use resource managed variants of irq_alloc_generic_chip() and >>>> irq_setup_generic_chip(). >>> >>> Is this really useful for drivers which can only be built-in? >> >> But you still can unbind the driver and its ->remove() will be called >> (in case of no remove, devres still on the table), right? > > Maybe the patches need to be combines with a > .suppress_bind_attrs = true in the driver struct? > > I backed out the patches I applied, I thought the series were older, > sorry stressed at work today. >
gpio-sodaville sets .supress_bind_attrs to true. Other built-in drivers need updates for that, but I think this could go in a separate series as using devres doesn't affect the bind/unbind functionality/issue.
Thanks, Bartosz
| |