Messages in this thread | | | Date | Wed, 2 Aug 2017 09:35:13 +0200 | From | Jiri Olsa <> | Subject | Re: [PATCH v1 03/15] perf, tools, stat: Fix saved values rbtree lookup |
| |
On Mon, Jul 24, 2017 at 04:40:03PM -0700, Andi Kleen wrote: > From: Andi Kleen <ak@linux.intel.com> > > The stat shadow saved values rbtree is indexed by a pointer. > Fix the comparison function: > > - We cannot return a pointer delta as an int because > that loses bits on 64bit. > - Doing pointer arithmetic on the struct pointer > only works if the objects are spaced by the multiple > of the object size, which is not guaranteed for individual > malloc'ed object > > Replace it with a proper comparison. > > This fixes various problems with values not being found. > > Signed-off-by: Andi Kleen <ak@linux.intel.com>
Acked-by: Jiri Olsa <jolsa@kernel.org>
thanks, jirka
| |