lkml.org 
[lkml]   [2017]   [Aug]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 082/134] usb: Make sure usb/phy/of gets built-in
    3.16.47-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Alexey Brodkin <Alexey.Brodkin@synopsys.com>

    commit 3d6159640da9c9175d1ca42f151fc1a14caded59 upstream.

    DWC3 driver uses of_usb_get_phy_mode() which is
    implemented in drivers/usb/phy/of.c and in bare minimal
    configuration it might not be pulled in kernel binary.

    In case of ARC or ARM this could be easily reproduced with
    "allnodefconfig" +CONFIG_USB=m +CONFIG_USB_DWC3=m.

    On building all ends-up with:
    ---------------------->8------------------
    Kernel: arch/arm/boot/Image is ready
    Kernel: arch/arm/boot/zImage is ready
    Building modules, stage 2.
    MODPOST 5 modules
    ERROR: "of_usb_get_phy_mode" [drivers/usb/dwc3/dwc3.ko] undefined!
    make[1]: *** [__modpost] Error 1
    make: *** [modules] Error 2
    ---------------------->8------------------

    Signed-off-by: Alexey Brodkin <abrodkin@synopsys.com>
    Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
    Cc: Geert Uytterhoeven <geert+renesas@glider.be>
    Cc: Nicolas Pitre <nicolas.pitre@linaro.org>
    Cc: Thomas Gleixner <tglx@linutronix.de>
    Cc: Felipe Balbi <balbi@kernel.org>
    Cc: Felix Fietkau <nbd@nbd.name>
    Cc: Jeremy Kerr <jk@ozlabs.org>
    Cc: linux-snps-arc@lists.infradead.org
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/Makefile | 1 +
    1 file changed, 1 insertion(+)

    --- a/drivers/Makefile
    +++ b/drivers/Makefile
    @@ -91,6 +91,7 @@ obj-$(CONFIG_USB_PHY) += usb/
    obj-$(CONFIG_USB) += usb/
    obj-$(CONFIG_PCI) += usb/
    obj-$(CONFIG_USB_GADGET) += usb/
    +obj-$(CONFIG_OF) += usb/
    obj-$(CONFIG_SERIO) += input/serio/
    obj-$(CONFIG_GAMEPORT) += input/gameport/
    obj-$(CONFIG_INPUT) += input/
    \
     
     \ /
      Last update: 2017-08-18 15:33    [W:5.840 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site