Messages in this thread | | | Date | Thu, 17 Aug 2017 22:03:43 -0700 (PDT) | Subject | Re: [PATCH V5 net-next 01/21] net-next/hinic: Initialize hw interface | From | David Miller <> |
| |
From: Stephen Hemminger <stephen@networkplumber.org> Date: Thu, 17 Aug 2017 17:42:05 -0700
> Please drop these functions, they do nothing and are not used > as stubs in any operations table.
It might have been helpful to scan the entire series to understand why it looks this way.
He's building the driver up, one piece at a time, filling in the full implementation as is possible as more and more infrastructure is added.
So some functions start empty when a method is needed to be filled in, and then gradually obtains more and more content throughout the series.
And this is a fine way to add a huge new driver (although not my personal preference).
| |