Messages in this thread | | | Date | Thu, 17 Aug 2017 14:36:02 -0700 | From | Darren Hart <> | Subject | Re: [PATCH 4/4] platform/x86: wmi: Fix check for method instance number |
| |
On Thu, Aug 17, 2017 at 11:13:19PM +0200, Pali Rohár wrote: > On Thursday 17 August 2017 08:24:31 Darren Hart wrote: > > On Sat, Aug 12, 2017 at 09:44:18AM +0200, Pali Rohár wrote: > > > instance_count defines number of instances of data block and instance > > > itself is indexed from zero, which means first instance has number 0. > > > Therefore check for invalid instance should be non-strict inequality. > > > > > > Signed-off-by: Pali Rohár <pali.rohar@gmail.com> > > > > This is correct per the WMI specification. Pali, now that Andy has > > applied 1-3 of this series, is that all the required driver updates? > > Hmmm... I have not understood your question. > > I checked that all drivers which uses instance id 1 have comment > explaining why is id 1 used. > > Problematic drivers without comment have either patch to use instance id > 0 in this series or somebody else already supplied patch which is part > of linus tree.
Perfect, that is what I was looking for. Thanks Pali!
> > > Reviewed-by: Darren Hart (VMware) <dvhart@infradead.org> -- Darren Hart VMware Open Source Technology Center
| |