lkml.org 
[lkml]   [2017]   [Aug]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/15] ALSA: es18xx: constify pnp_device_id and pnp_card_device_id
    Date
    *_device_id are not supposed to change at runtime. All functions
    working with *_device_id provided by <linux/pnp.h> work with
    const *_device_id. So mark the non-const structs as const.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    sound/isa/es18xx.c | 4 ++--
    1 file changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/isa/es18xx.c b/sound/isa/es18xx.c
    index ae17a65..5d4a30a 100644
    --- a/sound/isa/es18xx.c
    +++ b/sound/isa/es18xx.c
    @@ -2017,7 +2017,7 @@ static int isa_registered;
    static int pnp_registered;
    static int pnpc_registered;

    -static struct pnp_device_id snd_audiodrive_pnpbiosids[] = {
    +static const struct pnp_device_id snd_audiodrive_pnpbiosids[] = {
    { .id = "ESS1869" },
    { .id = "ESS1879" },
    { .id = "" } /* end */
    @@ -2062,7 +2062,7 @@ static int snd_audiodrive_pnp(int dev, struct snd_es18xx *chip,
    return 0;
    }

    -static struct pnp_card_device_id snd_audiodrive_pnpids[] = {
    +static const struct pnp_card_device_id snd_audiodrive_pnpids[] = {
    /* ESS 1868 (integrated on Compaq dual P-Pro motherboard and Genius 18PnP 3D) */
    { .id = "ESS1868", .devs = { { "ESS1868" }, { "ESS0000" } } },
    /* ESS 1868 (integrated on Maxisound Cards) */
    --
    2.7.4
    \
     
     \ /
      Last update: 2017-08-17 12:12    [W:3.927 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site