lkml.org 
[lkml]   [2017]   [Aug]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 0/1] devpts: use dynamic_dname() to generate proc name
    On Wed, Aug 16, 2017 at 3:46 PM, Eric W. Biederman
    <ebiederm@xmission.com> wrote:
    >> tty->link->driver_data = pts_path;
    >>
    >> retval = ptm_driver->ops->open(tty, filp);
    > ^^^^^^^
    >
    > If this open fails the code jumps to err_put_path which falls
    > through into out_put_fsi.

    No it doesn't.

    err_path_put falls through to err_release, but that then does a
    "return retval;". It doesn't get to out_put_fsi.

    Now, I _do_ want people to check the release path, but I don't think
    this was it. Or am I blind and missing something?

    Linus

    \
     
     \ /
      Last update: 2017-08-17 00:58    [W:4.074 / U:0.332 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site