lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 4/4] mmc: sdhci-cadence: add suspend / resume support
From
Date
On 14/08/17 18:28, Masahiro Yamada wrote:
> Hi Adrian,
>
>
> 2017-08-14 19:53 GMT+09:00 Adrian Hunter <adrian.hunter@intel.com>:
>
>>> @@ -353,6 +390,28 @@ static int sdhci_cdns_probe(struct platform_device *pdev)
>>> return ret;
>>> }
>>>
>>> +static int __maybe_unused sdhci_cdns_resume(struct device *dev)
>>
>> We don't use __maybe_unused in this case, we use #ifdef CONFIG_PM_SLEEP
>
>
> Could you tell me the reason
> why #ifdef CONFIG_PM_SLEEP is preferable?
>
> I see lots of __maybe_unused for suspend/resume hooks in drivers.

Not in sdhci drivers. It is easier for the maintainer to have consistency
across the code they maintain.

\
 
 \ /
  Last update: 2017-08-15 08:54    [W:1.118 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site