lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH 2/9] ASoC: cygnus: Update bindings for audio clock changes
    From
    Date

    On 8/15/2017 10:14 AM, Mark Brown wrote:
    > On Mon, Aug 14, 2017 at 03:06:50PM -0700, Lori Hikichi wrote:
    >> Allow each audio port to select which clock (if any) it wants to use.
    > Why is this in DT for the port and not either using standard clock
    > bindings to configure the clock tree or allowing the machine driver to
    > pick?
    The previous version of the driver essentially had a clock mapping
    that could not be changed. This is fine for 99% of our use cases.
    If we need to change the mapping, then we need to modify the audio
    port's clock mux. Creating a clock for these muxes was going to be messy.
    There is a mux per audio port and the registers used to program the
    muxes are staggered throughout the io space used by the audio driver.
    Additionally, these registers have bits that are controlled by the
    audio driver. Had I used syscon to access these registers this would
    have resulted in a very fragmented io space, complicating the audio
    drivers access this space.
    I have put the mux assignment in DT because the assignment is a
    static property and did not need run time programmability from the
    machine driver.

    Lori.

    \
     
     \ /
      Last update: 2017-08-15 21:30    [W:5.137 / U:2.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site