Messages in this thread | | | From | Kees Cook <> | Date | Tue, 15 Aug 2017 12:01:07 -0700 | Subject | Re: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps" |
| |
On Tue, Aug 15, 2017 at 4:55 AM, Petr Mladek <pmladek@suse.com> wrote: > On Thu 2017-08-10 13:36:35, Kees Cook wrote: >> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with >> various conflict clean-ups. >> >> With the default root directory mode set to 0750 now, the capability >> check was redundant. >> >> Suggested-by: Nick Kralevich <nnk@google.com> >> Signed-off-by: Kees Cook <keescook@chromium.org> > > The patch looks correct from the code side. I looked at > it because it touched printk.c. Note that I am not > security expert. > > Reviewed-by: Petr Mladek <pmladek@suse.cz>
Thanks!
-Kees
-- Kees Cook Pixel Security
| |