lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH net-next 11/11] net: dsa: debugfs: add port vlan
    From
    Date


    On 08/14/2017 03:22 PM, Vivien Didelot wrote:
    > Add a debug filesystem "vlan" entry to query a port's hardware VLAN
    > entries through the .port_vlan_dump switch operation.
    >
    > This is really convenient to query directly the hardware or inspect DSA
    > or CPU links, since these ports are not exposed to userspace.
    >
    > Here are the VLAN entries for a CPU port:
    >
    > # cat port5/vlan
    > vid 1
    > vid 42 pvid
    >
    > Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
    > ---
    > net/dsa/debugfs.c | 33 +++++++++++++++++++++++++++++++++
    > 1 file changed, 33 insertions(+)
    >
    > diff --git a/net/dsa/debugfs.c b/net/dsa/debugfs.c
    > index 98c5068d20da..b00942368d29 100644
    > --- a/net/dsa/debugfs.c
    > +++ b/net/dsa/debugfs.c
    > @@ -286,6 +286,34 @@ static const struct dsa_debugfs_ops dsa_debugfs_tree_ops = {
    > .read = dsa_debugfs_tree_read,
    > };
    >
    > +static int dsa_debugfs_vlan_dump_cb(u16 vid, bool pvid, bool untagged,
    > + void *data)
    > +{
    > + struct seq_file *seq = data;
    > +
    > + seq_printf(seq, "vid %d", vid);
    > + if (pvid)
    > + seq_puts(seq, " pvid");
    > + if (untagged)
    > + seq_puts(seq, " untagged");

    Personal preference: could we just specify something like:

    vid 1 (t)
    vid 42 (u) pvid

    to clearly show which VLAN is tagged/untagged?

    Other than that:

    Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
    --
    Florian

    \
     
     \ /
      Last update: 2017-08-15 19:41    [W:3.317 / U:0.744 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site