lkml.org 
[lkml]   [2017]   [Aug]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] Revert "pstore: Honor dmesg_restrict sysctl on dmesg dumps"
On Thu 2017-08-10 13:36:35, Kees Cook wrote:
> This reverts commit 68c4a4f8abc60c9440ede9cd123d48b78325f7a3, with
> various conflict clean-ups.
>
> With the default root directory mode set to 0750 now, the capability
> check was redundant.
>
> Suggested-by: Nick Kralevich <nnk@google.com>
> Signed-off-by: Kees Cook <keescook@chromium.org>

The patch looks correct from the code side. I looked at
it because it touched printk.c. Note that I am not
security expert.

Reviewed-by: Petr Mladek <pmladek@suse.cz>

Best Regards,
Petr

\
 
 \ /
  Last update: 2017-08-15 13:56    [W:0.118 / U:0.620 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site