lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 2/2] leds: lm3533: constify attribute_group structure
From
Date
Hi Amitoj,

Thanks for the patch, applied.

Best regards,
Jacek Anaszewski

On 08/10/2017 06:28 PM, Amitoj Kaur Chawla wrote:
> Functions working with attribute_groups provided by <linux/device.h>
> work with const attribute_group. These attribute_group structures do not
> change at runtime so mark them as const.
>
> File size before:
> text data bss dec hex filename
> 8272 4608 64 12944 3290 drivers/leds/leds-lm3533.o
>
> File size after:
> text data bss dec hex filename
> 8368 4512 64 12944 3290 drivers/leds/leds-lm3533.o
>
> This change was made with the help of Coccinelle.
>
> Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
> ---
> drivers/leds/leds-lm3533.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/leds/leds-lm3533.c b/drivers/leds/leds-lm3533.c
> index 5b529dc..72224b5 100644
> --- a/drivers/leds/leds-lm3533.c
> +++ b/drivers/leds/leds-lm3533.c
> @@ -626,7 +626,7 @@ static umode_t lm3533_led_attr_is_visible(struct kobject *kobj,
> return mode;
> };
>
> -static struct attribute_group lm3533_led_attribute_group = {
> +static const struct attribute_group lm3533_led_attribute_group = {
> .is_visible = lm3533_led_attr_is_visible,
> .attrs = lm3533_led_attributes
> };
>

\
 
 \ /
  Last update: 2017-08-14 22:47    [W:0.038 / U:1.876 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site