lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v3 1/3] irq/irq_sim: add a simple interrupt simulator framework
On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> 2017-08-14 15:06 GMT+02:00 Thomas Gleixner <tglx@linutronix.de>:
> > On Mon, 14 Aug 2017, Bartosz Golaszewski wrote:
> >
> >> Implement a simple, irq_work-based framework for simulating
> >> interrupts. Currently the API exposes routines for initializing and
> >> deinitializing the simulator object, enqueueing the interrupts and
> >> retrieving the allocated interrupt numbers based on the offset of the
> >> dummy interrupt in the simulator struct.
> >>
> >> Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>
> >> Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> >> ---
> >> include/linux/irq_sim.h | 44 ++++++++++++++++++
> >> init/Kconfig | 4 ++
> >> kernel/Makefile | 1 +
> >> kernel/irq_sim.c | 121 ++++++++++++++++++++++++++++++++++++++++++++++++
> >
> > Please move this to kernel/irq/ ... and the config option to kernel/irq/Kconfig.
> >
> > Thanks,
> >
> > tglx
> >
> >
>
> How about moving irq_work.c there too?

We could, but irq_work is not really part of the interrupt subsystem, while
your interrupt simulator definitely is.

Thanks,

tglx

\
 
 \ /
  Last update: 2017-08-14 16:49    [W:0.043 / U:1.944 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site