lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/2] watchdog: cadence_wdt: Enable access to module parameters
On Fri, Aug 04, 2017 at 09:39:16AM +0200, Michal Simek wrote:
> Give read access to module parameters to all and write access to root.
> This change also improves driver error path testing.
>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> ---
>
> Please let me know what you think - I can use macros from stat.h if
> required
>
You mean instead of 0644 ? That is discouraged nowadays.

Guenter

> ---
> drivers/watchdog/cadence_wdt.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/watchdog/cadence_wdt.c b/drivers/watchdog/cadence_wdt.c
> index 05c000081e9d..dadd3b0c2d49 100644
> --- a/drivers/watchdog/cadence_wdt.c
> +++ b/drivers/watchdog/cadence_wdt.c
> @@ -52,12 +52,12 @@
> static int wdt_timeout;
> static int nowayout = WATCHDOG_NOWAYOUT;
>
> -module_param(wdt_timeout, int, 0);
> +module_param(wdt_timeout, int, 0644);
> MODULE_PARM_DESC(wdt_timeout,
> "Watchdog time in seconds. (default="
> __MODULE_STRING(CDNS_WDT_DEFAULT_TIMEOUT) ")");
>
> -module_param(nowayout, int, 0);
> +module_param(nowayout, int, 0644);
> MODULE_PARM_DESC(nowayout,
> "Watchdog cannot be stopped once started (default="
> __MODULE_STRING(WATCHDOG_NOWAYOUT) ")");
> --
> 1.9.1
>

\
 
 \ /
  Last update: 2017-08-14 16:49    [W:0.060 / U:6.952 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site