lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 1/3] livepatch: Add force sysfs attribute
On Fri, 11 Aug 2017, Josh Poimboeuf wrote:

> On Thu, Aug 10, 2017 at 12:48:13PM +0200, Miroslav Benes wrote:
> > +static ssize_t force_store(struct kobject *kobj, struct kobj_attribute *attr,
> > + const char *buf, size_t count)
> > +{
> > + /*
> > + * klp_mutex lock is not grabbed here intentionally. It is not really
> > + * needed. The race window is harmless and grabbing the lock would only
> > + * hold the action back.
> > + */
> > + if (!klp_transition_patch) {
> > + pr_info("no patching in progress, forced action ineffective\n");
> > + return -EINVAL;
> > + }
> > +
> > + return -EINVAL;
> > +}
>
> I think this is really a minor issue, and the -EINVAL is enough. As the
> comment says, the race window is harmless. So I'd say there's no need
> to scare the user with a printk.

Ok, I'll remove it in v3.

Miroslav

\
 
 \ /
  Last update: 2017-08-14 16:04    [W:0.062 / U:12.136 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site