lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 1/2] kmemleak: Delete an error message for a failed memory allocation in two functions
From
Date
>> +++ b/mm/kmemleak.c
>> @@ -555,7 +555,6 @@ static struct kmemleak_object *create_object(unsigned long ptr, size_t size,
>>
>> object = kmem_cache_alloc(object_cache, gfp_kmemleak_mask(gfp));
>> if (!object) {
>> - pr_warn("Cannot allocate a kmemleak_object structure\n");
>> kmemleak_disable();
>
> I don't really get what this patch is trying to achieve.

I suggest to reduce the code size a bit.


> Given that kmemleak will be disabled after this,

I have got difficulties to interpret this information.


> I'd rather know why it happened.

Do you find the default allocation failure report sufficient?

Regards,
Markus

\
 
 \ /
  Last update: 2017-08-14 13:41    [W:0.053 / U:35.896 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site