lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 07/10] ASoC: pxa: constify snd_pcm_ops structures
    Date
    snd_pcm_ops are not supposed to change at runtime. All functions
    working with snd_pcm_ops provided by <sound/soc.h> work with
    const snd_pcm_ops. So mark the non-const structs as const.

    Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
    ---
    sound/soc/pxa/mmp-pcm.c | 2 +-
    sound/soc/pxa/pxa2xx-pcm.c | 2 +-
    2 files changed, 2 insertions(+), 2 deletions(-)

    diff --git a/sound/soc/pxa/mmp-pcm.c b/sound/soc/pxa/mmp-pcm.c
    index 5b5f1a4..e25f1c2 100644
    --- a/sound/soc/pxa/mmp-pcm.c
    +++ b/sound/soc/pxa/mmp-pcm.c
    @@ -131,7 +131,7 @@ static int mmp_pcm_mmap(struct snd_pcm_substream *substream,
    vma->vm_end - vma->vm_start, vma->vm_page_prot);
    }

    -static struct snd_pcm_ops mmp_pcm_ops = {
    +static const struct snd_pcm_ops mmp_pcm_ops = {
    .open = mmp_pcm_open,
    .close = snd_dmaengine_pcm_close_release_chan,
    .ioctl = snd_pcm_lib_ioctl,
    diff --git a/sound/soc/pxa/pxa2xx-pcm.c b/sound/soc/pxa/pxa2xx-pcm.c
    index b51d7a0..357981c 100644
    --- a/sound/soc/pxa/pxa2xx-pcm.c
    +++ b/sound/soc/pxa/pxa2xx-pcm.c
    @@ -45,7 +45,7 @@ static int pxa2xx_pcm_hw_free(struct snd_pcm_substream *substream)
    return 0;
    }

    -static struct snd_pcm_ops pxa2xx_pcm_ops = {
    +static const struct snd_pcm_ops pxa2xx_pcm_ops = {
    .open = __pxa2xx_pcm_open,
    .close = __pxa2xx_pcm_close,
    .ioctl = snd_pcm_lib_ioctl,
    --
    1.9.1
    \
     
     \ /
      Last update: 2017-08-14 07:59    [W:4.169 / U:0.272 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site