lkml.org 
[lkml]   [2017]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v7 2/5] genirq: Add handle_fasteoi_{level,edge}_irq flow handlers.
On Wed, 9 Aug 2017, David Daney wrote:
> #ifdef CONFIG_IRQ_DOMAIN_HIERARCHY

Can we please make them conditional in order not to bloat all kernels with
it? Like we do for handle_edge_eoi_irq() ?

> /**
> + * handle_fasteoi_edge_irq - irq handler for edge hierarchy
> + * stacked on transparent controllers
> + *
> + * @desc: the interrupt description structure for this irq
> + *
> + * Like handle_fasteoi_irq(), but for use with hierarchy where
> + * the irq_chip also needs to have its ->irq_ack() function
> + * called.
> + */
> +void handle_fasteoi_edge_irq(struct irq_desc *desc)
> +{
> + struct irq_chip *chip = desc->irq_data.chip;
> +
> + raw_spin_lock(&desc->lock);
> +
> + if (!irq_may_run(desc))
> + goto out;
> +
> + desc->istate &= ~(IRQS_REPLAY | IRQS_WAITING);
> +
> + /*
> + * If its disabled or no action available
> + * then mask it and get out of here:
> + */
> + if (unlikely(!desc->action || irqd_irq_disabled(&desc->irq_data))) {
> + desc->istate |= IRQS_PENDING;
> + mask_irq(desc);
> + goto out;
> + }
> +
> + kstat_incr_irqs_this_cpu(desc);
> + if (desc->istate & IRQS_ONESHOT)
> + mask_irq(desc);
> +
> + /* Start handling the irq */
> + desc->irq_data.chip->irq_ack(&desc->irq_data);
> +
> + preflow_handler(desc);
> + handle_irq_event(desc);

Hmm. That's quite different to the way we handle edge interrupts
normally. See handle_edge_irq() and handle_edge_eoi_irq().

Thanks,

tglx

\
 
 \ /
  Last update: 2017-08-14 12:25    [W:0.069 / U:1.500 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site