lkml.org 
[lkml]   [2017]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 6/7] iio: srf08: add buffered to device mode
On Thu, 3 Aug 2017 01:26:09 +0200
Andreas Klinger <ak@it-klinger.de> wrote:

> Add INDIO_BUFFER_TRIGGERED and INDIO_BUFFER_SOFTWARE to device mode
>
> Signed-off-by: Andreas Klinger <ak@it-klinger.de>
> ---
> drivers/iio/proximity/srf08.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/proximity/srf08.c b/drivers/iio/proximity/srf08.c
> index a63c272c3b22..ea238ab1066c 100644
> --- a/drivers/iio/proximity/srf08.c
> +++ b/drivers/iio/proximity/srf08.c
> @@ -437,7 +437,9 @@ static int srf08_probe(struct i2c_client *client,
>
> indio_dev->name = id->name;
> indio_dev->dev.parent = &client->dev;
> - indio_dev->modes = INDIO_DIRECT_MODE;
> + indio_dev->modes = INDIO_DIRECT_MODE
> + | INDIO_BUFFER_TRIGGERED
Huh.? Firstly I think only one of these is relevant and secondly
should be merged back into the original patch that added the support.

Also the triggered_buffer setup already set it for you...

So all in all, drop this patch.

Jonathan
> + | INDIO_BUFFER_SOFTWARE;
>
> /* srf02 is not using sensitivity nor max_range */
> if (id->driver_data == SRF02)

\
 
 \ /
  Last update: 2017-08-12 14:04    [W:0.030 / U:0.180 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site