lkml.org 
[lkml]   [2017]   [Aug]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v4 07/10] KVM: x86: remove not used pvclock_gtod_copy
On Thu, Aug 03, 2017 at 02:35:19PM +0200, Paolo Bonzini wrote:
> On 03/08/2017 01:21, Marcelo Tosatti wrote:
> >> - if (ka->use_master_clock ||
> >> - (gtod->clock.vclock_mode == VCLOCK_TSC && vcpus_matched))
> >> + if (ka->use_master_clock || vcpus_matched)
> >> kvm_make_request(KVM_REQ_MASTERCLOCK_UPDATE, vcpu);
> > Don't drop this. The masterclock scheme requires TSC for proper functioning
> > (or an analysis why its supposed with different HPET+TSC, for example).
>
> I think testing gtod->clock.vclock_mode is just an optimization?
> kvm_get_time_and_clockread would return false anyway and masterclock
> would not be enabled.
>
> Paolo

Right.


\
 
 \ /
  Last update: 2017-08-12 01:00    [W:0.089 / U:0.496 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site